Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing custom versions of python for graders #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Nov 11, 2024

Motivation

  • Sets us up for supporting Java
  • Allows us to offer higher versions of python, without breaking backwards compatibility with graders relying on python 3.10 behavior

Note that fields which may be useful for implementing e.g. sandboxed Java ARE NOT included in this change. I would rather add those changes in a separate PR, and keep the diff here smaller.

Implementation

This adds a new model, Language, which stores information about the language, binary path, and more. The field Assignment.language has been moved inside said model.

Important

Custom migrations were written in order to facilitate this transition with minimal problems.

The rest is just some restructuring:

  • Changes the run_submission task to use the assignments executable
  • Filters the edit assignment/create venv to only show non-deprecated language options.
  • Changes the create_venv task to use the correct executable, and

TODO

Stuff to do until this PR is ready to review (feel free to help!)

  • Add Language model
  • Write custom migrations to handle data changes
  • Figure out why unmigrating fails
  • Update assignment editing UI to reflect this
  • Change internal tasks to use the correct language/binary paths
  • Figure out how to handle java paths & python language grader

@JasonGrace2282 JasonGrace2282 self-assigned this Nov 11, 2024
@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review November 14, 2024 03:44
@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner November 14, 2024 03:44
@JasonGrace2282 JasonGrace2282 marked this pull request as draft November 14, 2024 04:39
@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review November 15, 2024 03:54
@JasonGrace2282 JasonGrace2282 force-pushed the choose-python branch 4 times, most recently from 403c0bf to 46e2c8d Compare November 16, 2024 15:57
Custom migrations were written to safely transfer data,
and handle deprecated languages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants