INT-3299: Fixed id prop logging a warning when it shouldn't #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danoaky-tiny
requested review from
spocke,
TheSpyder and
ltrouton
and removed request for
a team
danoaky-tiny
requested review from
ArvinJ-H,
MitchC1999,
tiny-ben-tran,
shanmen-tiny and
jscasca
danoaky-tiny
force-pushed
the
feature/INT-3299
branch
from
bd092c8
to
c193e64
Compare
MitchC1999
approved these changes
Jun 20, 2024
ltrouton
approved these changes
Jul 8, 2024
danoaky-tiny
added a commit
that referenced
this pull request
Jul 8, 2024
* INT-3298: Added TestHooks.ts * INT-3298: Added TestHelpers.ts * INT-3298: support for using minitature to specify tinymce version * INT-3298: Migrated LoadTinyTest to BDD style * INT-3298: throwTimeout message param is now optional * INT-3298: Migrated NgZoneTest.ts to BDD style * INT-3298: Initial migration changes to NgModelTest.ts * INT-3298: Added a *Test.ts eslint override * INT-3298: Refactored EditorFixture to extend ComponentFixture * INT-3298: Increased skin load timeout * INT-3298: loadedEditor$ is reset in now reset in a beforeEach * INT-3298: Removed old tests in NgModelTest.ts * INT-3298: Enabled `destroyAfterEach` teardown option * INT-3298: Refactored TestHooks.ts to account for teardown option being turned on now * INT-3298: Refactored migrated tests to new TestHooks.ts changes * INT-3298: Refactor to use `eachVersionContext` * INT-3298: `editorHook` can now be used with a single standalone component, removing the need for editorHookStandalone * INT-3298: Migrated EventBlacklistingTest.ts to BDD style Also removed TestStore.ts as it's no longer needed. * INT-3298: Added **/test/ts/**/*.ts to test eslint override * INT-3298: Moved fakeType to TestHelpers.ts * INT-3298: Added FormGroup test with default and onpush change detection * INT-3299: Fixed id prop logging a warning when it shouldn't (#392) * INT-3299: Check that an existing element with an id does not equal the current elementRef * INT-3299: Added captureLogs function * INT-3299: Added chai package for testing as well allowing it in eslint * INT-3299: Added PropTest.ts * INT-3299: Removed a comment * INT-3299: Increased timeout * INT-3299: use a `pTryUntil` instead of `waitForEditorsToLoad` * INT-3298: Added a changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: INT-3299
Changes:
captureLogsfunction.Relevant Github Issue: #374