Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 192 no tablesorter #193

Closed
wants to merge 2 commits into from
Closed

Conversation

jkeenan
Copy link
Collaborator

@jkeenan jkeenan commented Sep 11, 2021

This pull request should be considered a first-draft of a response to #192 filed by @shawnlaffan. In this branch we drop jquery.tablesorter.min.js entirely.

This gives me good results on Linux in Firefox, Chromium, Chrome and Opera. However, it needs to be tested in real-life situations on Windows and other OSes as well. We will also have to examine the history of this jquery file within this library, so that we know what we might be losing if we drop it.

Please review.

@timbunce
Copy link
Owner

I'm puzzled.
Does this remove the ability to sort tables at all?
That seems like a drastic response to the problem at hand.
Removing floatThead, reverting to an early state, seems like a better approach.

p.s. I recommend not updating VERSION till you're ready to release. Or, alternately, update it in a separate PR. Either way will avoid problems if, for example, you wanted to revert a PR, or the PR doesn't get merged into the release it was intended to.

jkeenan added a commit to jkeenan/devel-nytprof that referenced this pull request Sep 13, 2021
This is the second attempt to respond to the problem described in
timbunce#192.  In this attempt
we take into consideration the concerns raised by Tim Bunce in
timbunce#193 (comment).
@jkeenan
Copy link
Collaborator Author

jkeenan commented Sep 13, 2021

I'm puzzled.
Does this remove the ability to sort tables at all?
That seems like a drastic response to the problem at hand.
Removing floatThead, reverting to an early state, seems like a better approach.

p.s. I recommend not updating VERSION till you're ready to release. Or, alternately, update it in a separate PR. Either way will avoid problems if, for example, you wanted to revert a PR, or the PR doesn't get merged into the release it was intended to.

Pausing this p.r. in favor of #194.

@jkeenan
Copy link
Collaborator Author

jkeenan commented Sep 19, 2021

#194 has been merged into master, so this p.r. is now superseded and closable.

@jkeenan jkeenan closed this Sep 19, 2021
@jkeenan jkeenan deleted the gh-192-no-tablesorter branch September 19, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants