improvements from cperl #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the two plugins to latest, and adjusted the tablesorter css.
make it work as cpan/Devel-NYTProf extension. fix the compiler warnings with cperl we dont need the XSLoader workaround pass podchecker
as needed by cmd.exe
These diagnostics are ony useful for failing cpantesters reports but not in core.
File::Which is not in core. prefer scriptdir over bin. rather use our hardcoded path to find the other tools. also fallback to Cpanel::JSON::XS from JSON::MaybeXS, which is also not in core
and the undefined OP_SETSTATE warning. Note that a dev. version 6.04_01 fails in the t/40-savesrc.t test
XSLoad the XS_VERSION string, not cleaned up float VERSION
change the enum tag to an int.
warning: passing an object that undergoes default argument promotion to
va_start has undefined behavior [-Wvarargs]
Resource leak detected by coverity
in format arg
newer darwins since macOS 10.12 do have clock_gettime with clockid_t as 1st arg, which fails to cast to IV with c++. change this argument to long, and fix the remaining clock_gettime() calls to use the CLOCK_GETTIME macro.
adjust one printf format from IV to long.
Fix new Autovivified hash slice warning, cperl-only
Closes Coverity CID #165315
5.27.7/5.27.3c started disallowing &PL_sv_yes as sub for silently ignoring a missing import/unimport. RT #63790 / timbunce#113 TODO: get an invalid SP after importing NYTProf, with empty import sub.
only with <5.11
use a c suffix. not used in any reader code
the c99 names.
Bug detected by scan-build: Branch condition evaluates to a garbage value. subname_gv_ptr == NULL holds a garbage stack value of dummy_gv. Initialize it.
for all Currently a developer-only test checks
and disable the test_one_dot rule: .indent.pro, .travis.yml, t/test02.pf.csv
VERSION is just the numified variant
skip zlib -m32 cross-compiled skip touch t/test40pmc.pmc if it does not exist skip exit 0
or adjust this testdata for early versions
strict is a builtin in cperl, rather use vars.
to get a functions cop. does not fix many undef-undef lines yet
describe eval context deviation from deb_curcv. handle faked sort sub. fix some typos, re-add some tracing
import calls were previously ignored. now they appear, with cperl even named.
cperl-5.39.2 shipped with 6.06_02 but without the jquery security fixes.
rurban
force-pushed
the
cperl-core
branch
7 times, most recently
from
1ae676a to
81c4f07
Compare
workaround cperl not storing main:: prefixes in %DBsub keys. add it manually for perl5 compat. add . to @inc in core to be able to expand the test filenames. use alloca() for the first time in cperl (cperl only though) silence hashiter warning since v5.29.1c: "Attempt to change hash while iterating over it" in SubInfo while (each %$cb) { delete $cb->{$line} } skipped tests with cperl5.28: t/42-global.t (Wstat: 8192 Tests: 289 Failed: 32) t/70-subname.t (Wstat: 4096 Tests: 57 Failed: 16) t/test40pmc.t (Wstat: 4096 Tests: 113 Failed: 16) t/test50-disable.t (Wstat: 7168 Tests: 113 Failed: 28) t/test51-enable.t (Wstat: 19456 Tests: 161 Failed: 76) t/test60-subname.t (Wstat: 7168 Tests: 65 Failed: 28) t/test62-subcaller1.t (Wstat: 7168 Tests: 65 Failed: 28)
This was referenced Apr 9, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where it's in core for some years.
cperl-compat,
various other fixes