tweak: hacky fix for spaces in usernames for /AddAdmin and /RemoveAdmin

also includes a fix for crashing after 10 commands are sent to the server
tiltedphoques · Aug 18, 2024 · f771f8c · f771f8c
1 parent 57aeaca
commit f771f8c
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 5 deletions.
diff --git a/Code/components/console/ConsoleRegistry.cpp b/Code/components/console/ConsoleRegistry.cpp
@@ -258,7 +258,7 @@ void ConsoleRegistry::StoreCommandInHistory(const TiltedPhoques::String& acLine)
     // Do some housekeeping.
     if (m_commandHistory.size() == 10)
     {
-        m_commandHistory.erase(m_commandHistory.end());
+        m_commandHistory.pop_back();
     }
 }
 

diff --git a/Code/server/GameServer.cpp b/Code/server/GameServer.cpp
@@ -412,15 +412,36 @@ void GameServer::BindServerCommands()
 
             if (!playerFound)
             {
-                out->warn("{} is not a valid player", cUsername.c_str());
+                // space in username handling
+                String backupUsername = cUsername;
+                if (cUsername.find('_') != std::string::npos)
+                {
+
+                    while (backupUsername.find('_') != std::string::npos)
+                    {
+                        std::ranges::replace(backupUsername, '_', ' ');
+                    }
+
+                    PlayerManager::Get()->ForEach([&](const Player* apPlayer) {
+                        if (apPlayer->GetUsername() == backupUsername)
+                        {
+                            AddAdminSession(apPlayer->GetConnectionId());
+                            out->info("{} admin privileges added", backupUsername.c_str());
+                            playerFound = true;
+                            return;
+                        }
+                    });
+
+                }
+                if (!playerFound)
+                    out->warn("{} is not an admin", backupUsername.c_str());
             }
         });
     m_commands.RegisterCommand<std::string>(
         "RemoveAdmin", "Remove admin privileges from player", [&](Console::ArgStack& aStack) {
             auto out = spdlog::get("ConOut");
 
             const auto& cUsername = aStack.Pop<String>();
-
             bool playerFound = false;
 
             for (const auto& cAdmin : m_adminSessions)
@@ -437,11 +458,35 @@ void GameServer::BindServerCommands()
 
             if (!playerFound)
             {
-                out->warn("{} is not an admin", cUsername.c_str());
+                // space in username handling
+                String backupUsername = cUsername;
+                if (cUsername.find('_') != std::string::npos)
+                {
+
+                    while (backupUsername.find('_') != std::string::npos)
+                    {
+                        std::ranges::replace(backupUsername, '_', ' ');
+                    }
+
+                    for (const auto& cAdmin : m_adminSessions)
+                    {
+                        Player* pPlayer = PlayerManager::Get()->GetByConnectionId(cAdmin);
+                        if (pPlayer->GetUsername() == backupUsername)
+                        {
+                            RemoveAdminSession(pPlayer->GetConnectionId());
+                            out->info("{} admin privileges revoked", backupUsername.c_str());
+                            playerFound = true;
+                            break;
+                        }
+                    }
+
+                }
+                if (!playerFound)
+                    out->warn("{} is not an admin", backupUsername.c_str());
             }
         });
     m_commands.RegisterCommand<>(
-        "admins", "List all admins", [&](Console::ArgStack& aStack) {
+        "admins", "List all admins", [&](Console::ArgStack&) {
             auto out = spdlog::get("ConOut");
             if (m_adminSessions.size() == 0)
             {