Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile #2

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Add Dockerfile #2

merged 1 commit into from
Nov 8, 2017

Conversation

iandees
Copy link
Member

@iandees iandees commented Oct 24, 2017

No description provided.

@iandees iandees changed the title WIP: Add Dockerfile Add Dockerfile Nov 7, 2017
zerebubuth
zerebubuth approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@zerebubuth zerebubuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good to me. 🚢

@rmarianski
Copy link
Member

We don't currently do it for xonacatl, but we might want to consider a way to peg specific versions of the dependencies.

@zerebubuth
Copy link
Member

a way to consider a way to peg specific versions of the dependencies.

Yup. The currently-fashionable "Go way" to do this seems to be go dep. I've added #4 to track that.

@iandees iandees merged commit abbe874 into master Nov 8, 2017
@iandees iandees deleted the iandees/dockerize branch November 8, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerebubuth zerebubuth zerebubuth approved these changes

@rmarianski rmarianski rmarianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iandees @rmarianski @zerebubuth