Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value for max_zoom_with_changes #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rwrx
Copy link

@rwrx rwrx commented May 30, 2024

Add value for max_zoom_with_changes parameter in format_coord in tilequeue as latest version of tilequeue requires this parameter. I am not sure whether value of nominal_zoom+1 is correct.

@nvkelso nvkelso requested review from rmarianski and iandees May 30, 2024 18:07
@@ -261,6 +261,7 @@ def handle_request(self, request):
formatted_tiles, extra_data = format_coord(
coord,
nominal_zoom,
nominal_zoom+1,
Copy link
Member

@nvkelso nvkelso May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this should be 16 instead of nominal_zoom+1?

Please give that a try and let me know if you still get your expected results!

See also:

Copy link
Member

@nvkelso nvkelso May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(That's for a typical zoom 15 at 512px tile size max_zoom... so if you want zoom 14 you may need to try also setting this locally to 15 instead... but the PR here should be for the generic case.)

Copy link
Author

@rwrx rwrx May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have previously tried to hardcode there 16 instead of nominal_zoom+1, but I did not get expected results. For me it seems that there should be 17.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's been a while since I've been familiar with the details, but I expect that nominal zoom (display zoom) is actually what we want here. If features are not appearing, could it be because the features on those properties aren't set appropriately? (Treat this with a grain of salt since I don't have the context)

Copy link
Author

@rwrx rwrx May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nominal_zoom could be a proper solution. But in my case I need it to be nominal_zoom+1, because I do generate tiles for offline maps and I stop at zoom 14, I cannot go to zoom 15 because the file size of offline map will be too high. So I overzoom from zoom 14 to 16 and then add +1 to max_zoom_with_changes parameter. But in a general case where all zoom levels are available it should be only nominal_zoom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants