Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 1.0.0 #71

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Add changelog for 1.0.0 #71

merged 1 commit into from
Oct 6, 2016

Conversation

rmarianski
Copy link
Member

@zerebubuth, @nvkelso could you review please?

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage remained the same at 95.033% when pulling 0262f84 on changelog-1.0.0 into 75eb75a on master.

@nvkelso
Copy link
Member

nvkelso commented Oct 4, 2016

Please reorder and consolidate like:

  • Generate more valid polygons and multipolygons using pyclipper library for v2 MVT compliance (but we're still not fully v2 compliant for other reasons).
  • Handle edge cases where polygon buffer makes a multi-polygon, ensuring inner rings are dropped when subtracting them from the polygon would make it invalid, and not adding multipolygons as array elements for multipolygon constructor.
  • Calculate area more properly by using PolyTree result from Clipper.
  • Factor out polygon validity code into its own file.

@nvkelso
Copy link
Member

nvkelso commented Oct 4, 2016

You also need to update the version, which is here:

@rmarianski
Copy link
Member Author

Updates in 359c80f.

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage remained the same at 95.033% when pulling 359c80f on changelog-1.0.0 into 75eb75a on master.

@rmarianski rmarianski merged commit e4dde18 into master Oct 6, 2016
@rmarianski rmarianski deleted the changelog-1.0.0 branch October 6, 2016 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants