-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dmr1 for Slovenia and fixed srtm #196
base: master
Are you sure you want to change the base?
Conversation
…ex and source files for srtm, as the srtm script fails. You also need to install PDAL with either LASzip or LAZperf
Wow, great work! And thanks for including tests. Can you look into the line encodings, there's a lot of diff showing here for things I don't think you changed? Is you intention to build locally and distribute the changes yourself (totally works!) or to incorporate them into the next build of the Nextzen / AWS open terrain project? That operational code is in https://github.com/mojodna/marblecutter and related repos. |
Yes, my intention is to incorporate the new dataset into AWS open terrain project. We are using the AWS terrain tiles for BTE (Build The Earth), a project where we want to create a 1 to 1 copy of the world in Minecraft. But, when I noticed the poor quality of the terrain in my country, I first decided to generate my own tiles from the lidar data, locally. Later I pushed the idea, to use this dataset to generate the terrain anew, so I was assigned the role of a dev of our build team and decided the best plan of action would be to push this dataset directly to the AWS terrain tiles, which would benefit us, and other users of AWS terrain tiles. And about the diff, I'll look into it. Probably happened when I pasted the whole code into Sublime Text, instead of just the modified code. |
Turned out, had some problems with tile overlapping, transparency, and height because I was the wrong function to move the file to the store. And about the link you've posted. If I understand correctly, I have to follow the procedure, for these dataset to be updated on s3? |
Wait, on a second read, what do you mean by "distribute the changes yourself"? I can build it locally, but how would I update the data on s3.amazonaws.com/elevation-tiles-prod? |
To update data at In the meantime... you can build these new tiles yourself and you'd need to do something like a bbox limit to load tiles within some bbox area from your sidecar, else source from the public data bucket. |
Ok, I'll add bbox limit in the config for the source. Also, is there a way I can contact you, for further questions? |
…nd height of 1001 for tiles and fixed the incorrect tile bounds by switching to a pre-made index file (79.71% complete)
Ok, now I've fixed the tile bounds as they were incorrectly set, by switching to a pre-made index file. I've created my own script that supports multithreading for downloading and cropping the dataset to the border. I've bought a cheap used PC for 170€ to run the two scripts, as I download and crop the dataset in regions. The second crop script gets the actual tile bounds and add's it to the whitelist, and that's how the pre-made index gets updated. So far I've downloaded about 79.71% of the dataset. From reading the various docs about how the data get processed, if I understand correctly, the tiles need to get optimized to cloud-optimized GeoTIFF's, and overviews and vrt's need to be created and then uploaded to S3. I'm a college student and I've looked at the pricing for the S3 storage, and I could probably afford it, the problems are with the other services, like Lambda, API Gateway, IAM, EC2. I'm not sure if I could afford them, because, as I've said, I'm just a college student and I'm doing this as a part of another global volunteer project. Other than that, I have no problem creating a multithreaded script that would cloud-optimize each GeoTIFF and upload it to S3. |
Update, I've now downloaded the whole dataset. |
The following items were changed/added:
Now regarding the data source (DMR1). It's created from OTR, which is a laz file, containing only the terrain and Its resolution is 1m. OTR then gets processed, and a grided point cloud is created, and then saved in a text file. More can be read here
Running the test config (without srtm) and converting it to the terrarium format using QGIS produces the following:
And here is a comparison with the current data set, and the proposed new one:
Also on commit 81e0b62, the message was supposed to be "Remove otr source and replaced with dmr1", but had a typo.
If anything needs to be changed/fixed I am happy to oblige.