Add methods and tools to ensure spatial metadata properties for MBTiles databases #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 6, 2023 12:34
|
I can see the checks are failing because the I am not wed to Go 1.23 but the requirements should probably be bumped to Go 1.21 since I think previous versions have been EOL-ed. |
iandees
approved these changes
Sep 11, 2024
|
If you can rebase or merge in my change in #28 should allow compiling Go 1.23. |
Co-authored-by: Ian Dees <[email protected]>
Co-authored-by: Ian Dees <[email protected]>
|
Do you need me to do anything else for this? |
|
Nope, sorry didn't see the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.3 of the MBTiles spec says:
This PR adds methods to ensure those metadata properties are assigned when a new database is created and tools to update existing database.
This PR introduces backwards incompatible changes to the
tilepack.TileOutputterinterface:AssignSpatialMetadata(orb.Bound, maptile.Zoom, maptile.Zoom) errormethod.This PR introduces backwards incompatible changes to the
tilepack.MbtilesReaderinterface:Metadata() (*MbtilesMetadata, error)method.This PR introduces a new
MbtilesMetadatafor working with MBTiles metadata properties.The PR updates the
cmd/buildandcmd/mergetools to call theMbtilesMetadataon their respective tile "outputters". Additionally thecmd/mergetool has been updated to derive the updated bounds and min/max zoom levels for the set of MBTiles databases being merged.This PR updates dependencies to their most recent version and requires Go 1.23.
Aside from the backwards incompatible changes to the interfaces this PR introduces no outward facing changes. All the command line tools work the same way and all the tests pass.