Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix panic when minResolvedTS is not initialized #8965

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 2, 2025

What problem does this PR solve?

Issue Number: Close #8964.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jan 2, 2025
@rleungx rleungx requested review from lhy1024 and okJiang January 2, 2025 03:56
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.30%. Comparing base (5ad4301) to head (8cb18dc).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8965      +/-   ##
==========================================
+ Coverage   76.28%   76.30%   +0.02%     
==========================================
  Files         465      465              
  Lines       70537    70537              
==========================================
+ Hits        53810    53826      +16     
+ Misses      13379    13365      -14     
+ Partials     3348     3346       -2     
Flag Coverage Δ
unittests 76.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 2, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 2, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 2, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-02 04:20:37.327362405 +0000 UTC m=+583372.683366945: ☑️ agreed by lhy1024.
  • 2025-01-02 06:09:11.054336798 +0000 UTC m=+589886.410341330: ☑️ agreed by okJiang.

@rleungx
Copy link
Member Author

rleungx commented Jan 2, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0bfa31f into tikv:master Jan 2, 2025
26 checks passed
@rleungx rleungx deleted the fix-panic8 branch January 2, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PD panic on c.minResolvedTS.Load().(uint64)
3 participants