-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: introduce the connection ctx manager #8940
Conversation
3a92119
to
9a6c85f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8940 +/- ##
==========================================
- Coverage 76.28% 76.24% -0.04%
==========================================
Files 463 464 +1
Lines 70474 70516 +42
==========================================
+ Hits 53760 53767 +7
- Misses 13368 13395 +27
- Partials 3346 3354 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
9a6c85f
to
f39ad8c
Compare
0eb408a
to
192f36e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
192f36e
to
62e20a2
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: JmPotato <[email protected]>
62e20a2
to
f84cf99
Compare
What problem does this PR solve?
Issue Number: ref #8690.
What is changed and how does it work?
Check List
Tests
Release note