Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource control: fix unsafe usage of time.After and timer.Reset #8928

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Dec 17, 2024

What problem does this PR solve?

Issue Number: Close #8876

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. cherry-pick-approved Cherry pick PR approved by release team. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Dec 17, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 17, 2024
@rleungx rleungx added the type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. label Dec 18, 2024
@ti-chi-bot ti-chi-bot bot removed the type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. label Dec 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

@rleungx: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-8.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 10:20:09.668941777 +0000 UTC m=+952199.757744315: ☑️ agreed by rleungx.
  • 2024-12-20 03:19:51.232248775 +0000 UTC m=+1186181.321051313: ☑️ agreed by bufferflies.

@ti-chi-bot ti-chi-bot bot merged commit c1ee9cf into tikv:release-8.1 Dec 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants