*: unify the error definition #8902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
dco-signoff: yes
rleungx
force-pushed
the
unify-error-definition
branch
from
f1ebf38 to
fdbd7ef
Compare
ti-chi-bot
bot
added
size/XXL
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8902 +/- ##
==========================================
+ Coverage 76.25% 76.26% +0.01%
==========================================
Files 461 461
Lines 70395 70380 -15
==========================================
- Hits 53677 53675 -2
+ Misses 13372 13358 -14
- Partials 3346 3347 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
okJiang
reviewed
Dec 13, 2024
|
|
||
| // keyspace errors | ||
| var ( | ||
| // ErrKeyspaceNotFound is used to indicate target keyspace does not exist. |
There was a problem hiding this comment.
Are these comments necessary?
There was a problem hiding this comment.
Just remain the same as before.
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
unify-error-definition
branch
from
9f7cf58 to
d6a7ce9
Compare
Signed-off-by: Ryan Leung <[email protected]>
lhy1024
approved these changes
Dec 18, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
okJiang
approved these changes
Dec 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Ref #8922.
What is changed and how does it work?
Check List
Tests
Release note