resource control: fix unsafe usage of timer.Reset (#8877) #8900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
added
dco-signoff: yes
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
bufferflies
reviewed
Dec 12, 2024
| // Before Go 1.23, the only safe way to use Reset was to call Timer.Stop and explicitly drain the timer first. | ||
| // We need be careful here, see more details in the comments of Timer.Reset. | ||
| // https://pkg.go.dev/time@master#Timer.Reset | ||
| func SafeResetTimer(t *time.Timer, d time.Duration) { |
There was a problem hiding this comment.
why not use client/timerutil/util.go
There was a problem hiding this comment.
it will introduce cycle import
rleungx
approved these changes
Dec 12, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
bufferflies
approved these changes
Dec 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8877
What problem does this PR solve?
Issue Number: Close #8876
What is changed and how does it work?
Check List
Tests
Release note