Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move some common libraries to the client/pkg directory #8858

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Move some common libraries to the `client/pkg` directory.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Nov 26, 2024
@JmPotato JmPotato requested review from okJiang and rleungx November 26, 2024 09:20
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.76%. Comparing base (f91605a) to head (1ebee22).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8858      +/-   ##
==========================================
- Coverage   75.82%   75.76%   -0.06%     
==========================================
  Files         460      460              
  Lines       70637    70637              
==========================================
- Hits        53557    53516      -41     
- Misses      13702    13735      +33     
- Partials     3378     3386       +8     
Flag Coverage Δ
unittests 75.76% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-26 09:24:48.692294787 +0000 UTC m=+542076.311949295: ☑️ agreed by rleungx.
  • 2024-11-26 10:01:50.953990479 +0000 UTC m=+544298.573644995: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit da0000a into tikv:master Nov 26, 2024
26 checks passed
@JmPotato JmPotato deleted the independent_client_pkg branch November 26, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants