*: remove store limit scene code #8819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
release-note-none
okJiang
approved these changes
Nov 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8819 +/- ##
==========================================
+ Coverage 75.21% 75.29% +0.07%
==========================================
Files 459 456 -3
Lines 71843 71608 -235
==========================================
- Hits 54035 53915 -120
+ Misses 14351 14266 -85
+ Partials 3457 3427 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
rleungx
approved these changes
Nov 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
approved
and removed
needs-1-more-lgtm
rleungx
reviewed
Nov 18, 2024
| @@ -51,7 +51,6 @@ func NewStoreCommand() *cobra.Command { | |||
| s.AddCommand(NewSetStoreWeightCommand()) | |||
| s.AddCommand(NewStoreLimitCommand()) | |||
| s.AddCommand(NewRemoveTombStoneCommand()) | |||
| s.AddCommand(NewStoreLimitSceneCommand()) | |||
There was a problem hiding this comment.
should we also remove store-limit-mode?
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
/hold cancel |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8818
What is changed and how does it work?
Check List
Tests
Release note