Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: return error when create grant/evict leader scheduler (#8760) #8769

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8760

What problem does this PR solve?

Issue Number: Ref #8759

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

Fix an issue that pd can't report error normally when creating grant/evict leader scheduler.

…he same success message (tikv#7802)

ref tikv#7672

Signed-off-by: husharp <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (e9bcf4f) to head (b198196).
Report is 6 commits behind head on release-7.1.

Files with missing lines Patch % Lines
server/api/scheduler.go 75.00% 2 Missing and 1 partial ⚠️
server/handler.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #8769      +/-   ##
===============================================
+ Coverage        74.75%   74.76%   +0.01%     
===============================================
  Files              412      412              
  Lines            41930    41974      +44     
===============================================
+ Hits             31344    31383      +39     
- Misses            7824     7836      +12     
+ Partials          2762     2755       -7     
Flag Coverage Δ
unittests 74.76% <72.22%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 09:44:17.827243369 +0000 UTC m=+861370.666398908: ☑️ agreed by rleungx.
  • 2024-11-05 07:02:55.238054635 +0000 UTC m=+938088.077210178: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit ba7d856 into tikv:release-7.1 Nov 5, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants