test: add ut to test the input when creating evict-leader scheduler #8768
Conversation
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
Signed-off-by: okJiang <[email protected]>
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8768 +/- ##
==========================================
- Coverage 75.75% 75.64% -0.12%
==========================================
Files 461 461
Lines 72293 72298 +5
==========================================
- Hits 54767 54687 -80
- Misses 14028 14112 +84
- Partials 3498 3499 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/retest |
| @@ -113,11 +113,16 @@ func (h *schedulerHandler) CreateScheduler(w http.ResponseWriter, r *http.Reques | |||
| return | |||
| } | |||
| case types.GrantLeaderScheduler, types.EvictLeaderScheduler: | |||
| storeID, ok := input["store_id"].(float64) | |||
| _, ok := input["store_id"] | |||
There was a problem hiding this comment.
_, ok := input["store_id"] represents the input("store_id") doesn't exist.
storeID, ok := input["store_id"].(float64) represents the input("store_id") can not be convert to float.
So I split them to report different error messages.
There was a problem hiding this comment.
I think we can put it here. It won't be bad at all.
|
/cc @lhy1024 |
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
Check List
Tests
Release note