Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctl: sort gc safepoint in pd-ctl #7233

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Oct 19, 2023

What problem does this PR solve?

Issue Number: Close #7262

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
image

Code changes

Side effects

Related changes

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Oct 19, 2023
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and Yisaer October 19, 2023 09:09
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2023
Signed-off-by: bufferflies <[email protected]>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 23, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 23, 2023
@nolouch
Copy link
Contributor

nolouch commented Oct 23, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 179c607

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #7233 (179c607) into master (459671f) will increase coverage by 0.12%.
Report is 2 commits behind head on master.
The diff coverage is 7.69%.

❗ Current head 179c607 differs from pull request most recent head d7aae40. Consider uploading reports for the commit d7aae40 to get more accurate results

@@            Coverage Diff             @@
##           master    #7233      +/-   ##
==========================================
+ Coverage   74.34%   74.46%   +0.12%     
==========================================
  Files         446      442       -4     
  Lines       48200    47908     -292     
==========================================
- Hits        35833    35675     -158     
+ Misses       9201     9083     -118     
+ Partials     3166     3150      -16     
Flag Coverage Δ
unittests 74.46% <7.69%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lhy1024
Copy link
Contributor

lhy1024 commented Oct 26, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

@bufferflies: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 89128f1 into tikv:master Oct 26, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdctl: make gc safepoint more clear
4 participants