-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server:add querystats sync to follower pd #4922
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
regionLeaders := resp.GetRegionLeaders() | ||
hasStats := len(stats) == len(regions) | ||
hasBuckets := len(buckets) == len(regions) | ||
hasQueryStats := len(queryStats) == len(regions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it merge to hasStats
?
@@ -161,6 +164,7 @@ func (s *RegionSyncer) RunServer(ctx context.Context, regionNotifier <-chan *cor | |||
RegionStats: stats, | |||
RegionLeaders: leaders, | |||
Buckets: buckets, | |||
QueryStats: queryStats, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can queryStats
be merge into ReginStats
?
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Linking issues" section in the CONTRIBUTING.md. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: qidi1 [email protected]
What problem does this PR solve?
In PD now, QueryStat data is not synchronized and we can't get QueryStat data in non-leader nodes
Issue Number: #pingcap/tidb-dashboard/issues/1209
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note
Manual test
We ran a small cluster locally. On the cluster, test data was generated using the tiup bench tool. The results are shown in the figure below.