ThreadSafeCache Get method lock bug (#1008)

tikv · Mar 30, 2018 · e221ffb · e221ffb
1 parent 616b392
commit e221ffb
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/server/cache/cache.go b/server/cache/cache.go
@@ -67,9 +67,11 @@ func (c *threadSafeCache) Put(key uint64, value interface{}) {
 }
 
 // Get retrives an item from cache.
+// When Get method called, LRU and TwoQueue cache will rearrange entries
+// so we must use write lock.
 func (c *threadSafeCache) Get(key uint64) (interface{}, bool) {
-	c.lock.RLock()
-	defer c.lock.RUnlock()
+	c.lock.Lock()
+	defer c.lock.Unlock()
 	return c.cache.Get(key)
 }