*: Optimize executor runtime stats performance #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
13 tasks
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
crazycs520
changed the title
Signed-off-by: crazycs520 <[email protected]>
zyguan
reviewed
Dec 24, 2024
internal/locate/region_request.go
Outdated
| } | ||
|
|
||
| // GetRPCCount returns the total rpc types count. | ||
| func (r *RegionRequestRuntimeStats) GetRPCCount() int { |
There was a problem hiding this comment.
How about to use GetRPCStatsCount (or sth else)? This name make me think it returns the total number of RPCs of all cmd types.
internal/locate/region_request.go
Outdated
| // this is to avoid allocating map memory. | ||
| FirstRPCStats RPCRuntimeStats | ||
| // OtherRPCStatsMap uses to record another types of RPC requests. | ||
| OtherRPCStatsMap map[tikvrpc.CmdType]*RPCRuntimeStats |
There was a problem hiding this comment.
Just a suggestion, since one RegionRequestSender typically only send one (or a few) kind(s) of RPC, I guess we can just use a slice here to make the code clean and simple.
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
zyguan
approved these changes
Dec 25, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
cfzjywxk
approved these changes
Dec 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tiny optimize
RegionRequestRuntimeStatsandSnapshotRuntimeStatsby remove useless field and avoid create map.