pick-6.5: Support adaptive update interval for low resolution ts (#1484) #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
dco-signoff: yes
Signed-off-by: MyonKeminta <[email protected]> Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
ekexium
force-pushed
the
tidb-6.5-pick-1484
branch
from
b3f755a to
265712e
Compare
I initially planned to cherry-pick these changes in separate PRs. After taking a look now, since it's only 11 lines, let's combine them into one. |
…nd there's too much logs about setting the config (tikv#1502) Signed-off-by: MyonKeminta <[email protected]>
you06
approved these changes
Jan 7, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
MyonKeminta
reviewed
Jan 9, 2025
| @@ -47,19 +48,111 @@ import ( | |||
| "github.com/tikv/client-go/v2/metrics" | |||
| "github.com/tikv/client-go/v2/oracle" | |||
| pd "github.com/tikv/pd/client" | |||
| "go.uber.org/atomic" | |||
There was a problem hiding this comment.
Is there any reason to use the uber version rhe the original PR didn't? I think using the std one should be just fine🤔 Is this a mistake?
There was a problem hiding this comment.
std atomic was introduced in go 1.19, while release-6.5 uses go 1.18.
oracle/oracles/pd.go
Outdated
| // pdOracle is an Oracle that uses a placement driver client as source. | ||
| type pdOracle struct { | ||
| c pd.Client | ||
| // txn_scope (string) -> lastTSPointer (*lastTSOPointer) | ||
| lastTSMap sync.Map | ||
| quit chan struct{} | ||
| // The configured interval to update the low resolution ts. Set by SetLowResolutionTimestampUpdateInterval. | ||
| // For TiDB, this is directly controlled by the system variable `tidb_low_resolution_tso_update_interval`. |
…ikv#1491) Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: ekexium <[email protected]>
MyonKeminta
reviewed
Jan 9, 2025
oracle/oracles/pd.go
Outdated
Comment on lines
489
to
490
| // Note that as `doUpdate` updates last tick time while `nextUpdateInterval` may perform calculation depending on the | ||
| // last tick time, `doUpdate` should be called after finishing calculating the next interval. |
There was a problem hiding this comment.
Looks this is part of #1502 and don't need to be removed
…nd there's too much logs about setting the config (tikv#1502) Signed-off-by: MyonKeminta <[email protected]>
MyonKeminta
approved these changes
Jan 9, 2025
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MyonKeminta, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #1484 and #1502 to tidb-6.5