Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting concurrency for pipelined flush and resolveLocks #1494

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Nov 13, 2024

For tidb variable tidb_pipelined_dml_resource_policy

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2024
@ekexium ekexium requested review from you06 and cfzjywxk November 14, 2024 03:56
@ekexium ekexium force-pushed the config-flush-concurrency branch from 9935299 to d3adfc2 Compare December 6, 2024 01:26
@ekexium
Copy link
Contributor Author

ekexium commented Dec 10, 2024

@you06 @cfzjywxk PTAL when you have time, thanks

@ekexium ekexium force-pushed the config-flush-concurrency branch from ecf9e34 to 6b75b34 Compare December 10, 2024 13:00
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 10, 2024
Copy link

ti-chi-bot bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-10 13:13:12.375511689 +0000 UTC m=+357782.464314228: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 10, 2024
@cfzjywxk
Copy link
Contributor

@you06 PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants