cop: add kv read wall time to print result #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cfzjywxk <[email protected]>
Signed-off-by: cfzjywxk <[email protected]>
ekexium
reviewed
Mar 26, 2024
| @@ -663,6 +670,17 @@ func (td *TimeDetail) String() string { | |||
| return buf.String() | |||
| } | |||
|
|
|||
| // Merge merges the time detail into itself. | |||
| func (td *TimeDetail) Merge(detail *TimeDetail) { | |||
There was a problem hiding this comment.
To be used here https://github.com/pingcap/tidb/blob/master/pkg/distsql/select_result.go#L531 to record the TimeDetail information like the ScanDetail.
zyguan
approved these changes
Mar 27, 2024
ekexium
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kv read wall time which is the time consumed in tikv executors is not printted in the result.
It is helpful to check time consumed in the tikv next operations, for example processing column with larger values.