Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikvrpc: avoid data race on XxxRequest.Context #1242

Merged
merged 7 commits into from
Mar 22, 2024
Merged

tikvrpc: avoid data race on XxxRequest.Context #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5b804aa
tikvrpc: avoid data race on `XxxRequest.Context`
zyguan Mar 20, 2024
3f516a4
fix grammar of codegen comment
zyguan Mar 20, 2024
db4c87e
Merge branch 'master' into tidb-51921
zyguan Mar 20, 2024
39ac78f
address comments
zyguan Mar 20, 2024
ed18895
check diff of go generate
zyguan Mar 21, 2024
94c4d88
Merge branch 'master' into tidb-51921
zyguan Mar 22, 2024
40d20eb
fix a typo
zyguan Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ jobs:
with:
go-version: 1.21.6

- name: Go generate and check diff
run: |
go generate ./...
git diff --exit-code

- name: Lint
uses: golangci/golangci-lint-action@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion internal/locate/replica_selector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2518,7 +2518,7 @@ func TestReplicaReadAccessPathByGenError(t *testing.T) {

maxAccessErrCnt := 4
if israce.RaceEnabled {
// When run this test with race, it will take a long time, so we reduce the maxAccessErrCnt to 3 to speed up test to avoid timeout.
// When run this test with race, it will take a long time, so we reduce the maxAccessErrCnt to 2 to speed up test to avoid timeout.
maxAccessErrCnt = 2
}
totalValidCaseCount := 0
Expand Down
Loading
Loading