Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue that no available connections cause by concurrency request limit bug #1226

Merged
merged 9 commits into from
Mar 15, 2024

Conversation

crazycs520
Copy link
Contributor

Close #1225.

Data race issue #1222 should be fix in PR #1219.

internal/client/client_batch.go Outdated Show resolved Hide resolved
internal/client/client_batch.go Outdated Show resolved Hide resolved
@ekexium
Copy link
Contributor

ekexium commented Mar 14, 2024

I didn't get it very well. Why are we fixing it by checking sent > 0? Seems to me it should be fixed by making sure sent is always non-negative?

@crazycs520
Copy link
Contributor Author

I didn't get it very well. Why are we fixing it by checking sent > 0? Seems to me it should be fixed by making sure sent is always non-negative?

sent may be negative is cause by data race in issue #1222 , and I also have PR #1219 to do this fix, but I need to to more test to avoid regression as mentioned in #1219 (comment) , so I try to fix this bug without fix data race in this PR, since code freezes.

Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
@MyonKeminta MyonKeminta merged commit 5b6625f into tikv:master Mar 15, 2024
10 checks passed
@crazycs520 crazycs520 deleted the fix-qps-drop-0 branch March 15, 2024 06:28
crazycs520 added a commit to crazycs520/client-go that referenced this pull request May 22, 2024
…request limit bug (tikv#1226)"

This reverts commit 5b6625f.

Signed-off-by: crazycs520 <[email protected]>
crazycs520 added a commit to crazycs520/client-go that referenced this pull request May 22, 2024
…request limit bug (tikv#1226)"

This reverts commit 5b6625f.

Signed-off-by: crazycs520 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no available connections cause by concurrency request limit bug
4 participants