Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pipelined dml has its own max-txn-ttl of 24 hours #1224

Merged
merged 3 commits into from
Mar 14, 2024
Merged

feat: pipelined dml has its own max-txn-ttl of 24 hours #1224

merged 3 commits into from
Mar 14, 2024

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Mar 13, 2024

ref tikv/tikv#16291
Pipelined txn tends to run long. The default max TTL of 1 hour might not be enough.

@ekexium ekexium requested review from you06 and cfzjywxk March 13, 2024 10:58
cfzjywxk
cfzjywxk approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max txn ttl hehaviour should be explained in the docment too.

ekexium added 2 commits March 13, 2024 19:55
@ekexium
fix gh actions
f803116 
Signed-off-by: ekexium <[email protected]>
@ekexium
style: fix lint
190547f 
Signed-off-by: ekexium <[email protected]>
@ekexium ekexium merged commit d7000ea into tikv:master Mar 14, 2024
10 checks passed
@ekexium ekexium deleted the pipelined-dml-max-txn-ttl branch March 14, 2024 04:05
@ekexium ekexium mentioned this pull request Mar 17, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you06 you06 you06 approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekexium @cfzjywxk @you06