tikvrpc: avoid data race on XxxRequest.Context (#1242)

* tikvrpc: avoid data race on `XxxRequest.Context` Signed-off-by: zyguan <[email protected]> * fix grammar of codegen comment Signed-off-by: zyguan <[email protected]> * address comments Signed-off-by: zyguan <[email protected]> * check diff of go generate Signed-off-by: zyguan <[email protected]> * fix a typo Signed-off-by: zyguan <[email protected]> --------- Signed-off-by: zyguan <[email protected]>
tikv · Mar 22, 2024 · 05aaba6 · 05aaba6
1 parent 08aa706
commit 05aaba6
Show file tree

Hide file tree

Showing 6 changed files with 609 additions and 88 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -44,6 +44,11 @@ jobs:
         with:
           go-version: 1.21.6
 
+      - name: Go generate and check diff
+        run: |
+          go generate ./...
+          git diff --exit-code
+
       - name: Lint
         uses: golangci/golangci-lint-action@v3
         with:

diff --git a/internal/locate/replica_selector_test.go b/internal/locate/replica_selector_test.go
@@ -2518,7 +2518,7 @@ func TestReplicaReadAccessPathByGenError(t *testing.T) {
 
 	maxAccessErrCnt := 4
 	if israce.RaceEnabled {
-		// When run this test with race, it will take a long time, so we reduce the maxAccessErrCnt to 3 to speed up test to avoid timeout.
+		// When run this test with race, it will take a long time, so we reduce the maxAccessErrCnt to 2 to speed up test to avoid timeout.
 		maxAccessErrCnt = 2
 	}
 	totalValidCaseCount := 0