Collect setup keywords and uppercase variables #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maaharko
commented
Dec 5, 2024
maaharko
commented
- Modify all gloabl variables to use upper letters
- Unify and use combined keyword for suite setup
azbeleva
approved these changes
Dec 27, 2024
azbeleva
force-pushed
the
modify_common_setup_keyword_names
branch
8 times, most recently
from
0427b22 to
0bcf518
Compare
azbeleva
force-pushed
the
modify_common_setup_keyword_names
branch
5 times, most recently
from
4f28d67 to
377a4ac
Compare
Signed-off-by: Maarit Härkönen <[email protected]>
azbeleva
force-pushed
the
modify_common_setup_keyword_names
branch
from
377a4ac to
5c14b5c
Compare
azbeleva
approved these changes
Jan 3, 2025
leivos-unikie
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Line 15
Set Global Variable @{app_pids} @{found_pids}
is not consistent with the uppercase notation
Corresponding changes are required e.g. also in business-vm.robot
azbeleva
force-pushed
the
modify_common_setup_keyword_names
branch
3 times, most recently
from
7cb81b0 to
f999b20
Compare
leivos-unikie
approved these changes
Jan 3, 2025
Signed-off-by: Mariia Azbeleva <[email protected]>
azbeleva
force-pushed
the
modify_common_setup_keyword_names
branch
from
f999b20 to
f3eabd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.