Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint with "Cannot open: File exists" error #126

Merged
merged 4 commits into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ on:
- go.sum

jobs:
golangci:
# https://github.com/golangci/golangci-lint-action/issues/23
lint:
name: lint
runs-on: ubuntu-latest
steps:
Expand All @@ -24,7 +25,24 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: 1.21
go-version-file: './go.mod'

- name: golangci-lint
uses: golangci/[email protected]
with:
version: v1.55.2

fmt:
name: fmt
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v3

- name: Install Go
uses: actions/setup-go@v3
with:
go-version-file: './go.mod'

- name: Restore Go modules cache
uses: actions/cache@v3
Expand All @@ -49,9 +67,3 @@ jobs:
assert-nothing-changed go fmt ./...
assert-nothing-changed go mod tidy
exit $STATUS


- name: golangci-lint
uses: golangci/[email protected]
with:
version: v1.52.2
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
GOLANGCI_VERSION=v1.52.2
GOLANGCI_VERSION=v1.55.2
COVERAGE=coverage.out

.PHONY: deps
Expand Down
9 changes: 6 additions & 3 deletions pkg/tidbcloud/pingchat/models/pingchat_chat_info.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/tidbcloud/pingchat/models/pingchat_chat_message.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/tidbcloud/pingchat/models/pingchat_chat_response.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading