use filepath

.github/workflows/windows-test.yml

@@ -0,0 +1,13 @@
+name: test windows
+on:
+  pull_request:
+jobs:
+  tests:
+    runs-on: windows-latest
+    steps:
+      - uses: tidbcloud/setup-tidbcloud-cli@v0
+        with:
+          api_public_key: ${{ secrets.TIDB_CLOUD_API_PUBLIC_KEY }}
+          api_private_key: ${{ secrets.TIDB_CLOUD_API_PRIVATE_KEY }}
+      - name: run
+        run: ticloud serverless ls -p 1372813089191151295

internal/cli/serverless/export/download.go

@@ -222,9 +222,6 @@ func DownloadCmd(h *internal.Helper) *cobra.Command {
 }
 
 func DownloadFilesPrompt(h *internal.Helper, urls []*exportModel.V1beta1DownloadURL, path string, concurrency int) error {
-	if path == "" {
-		path = "."
-	}
 	if concurrency <= 0 {
 		concurrency = 3
 	}
@@ -311,10 +308,6 @@ type DownloadJob struct {
 }
 
 func DownloadFilesWithoutPrompt(h *internal.Helper, urls []*exportModel.V1beta1DownloadURL, path string, concurrency int) error {
-	if path == "" {
-		path = "."
-	}
-
 	// create the path if not exist
 	err := util.CreateFolder(path)
 	if err != nil {

internal/util/download.go

@@ -18,6 +18,7 @@ import (
 	"fmt"
 	"net/http"
 	"os"
+	"path/filepath"
 )
 
 // GetResponse returns the response of a given URL
@@ -39,13 +40,11 @@ func GetResponse(url string) (*http.Response, error) {
 
 // CreateFile creates a file if it does not exist
 func CreateFile(path, fileName string) (*os.File, error) {
-	if path == "" {
-		path = "."
-	}
-	if _, err := os.Stat(path + "/" + fileName); err == nil {
+	filePath := filepath.Join(path, fileName)
+	if _, err := os.Stat(filePath); err == nil {
 		return nil, fmt.Errorf("file already exists")
 	}
-	file, err := os.Create(path + "/" + fileName)
+	file, err := os.Create(filePath)
 	if err != nil {
 		return nil, err
 	}
@@ -54,6 +53,9 @@ func CreateFile(path, fileName string) (*os.File, error) {
 
 // CreateFolder creates a folder if it does not exist
 func CreateFolder(path string) error {
+	if path == "" {
+		return nil
+	}
 	if _, err := os.Stat(path); err != nil {
 		if os.IsNotExist(err) {
 			err = os.MkdirAll(path, 0755)