Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #979
Slice was failing on any slice
pN
of 1. This was because thebegin
of the next slice was being used to calculate the end of the first. Withslice 1 _
all slices begin at0.0
, so end is incorrectly set to0.0
.This implementation calculates the
end
control pattern by generating a sample-width pattern, and adding this to thebegin
pattern.Two tests are added:
slice
"can slice samples" - Regression test that passes ondev
and this branchslice
"can slice by 1" - Test for accurate calculation of sample end time when slicing into 1