Stack Cookie Cleanup #245
Merged
Stack Cookie Cleanup #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2024 12:03
edk2 PR tianocore/edk2#6433 cleans up the null stack cookie implementation, no longer requiring DSCs to manually add the null stack cookie lib to Sec modules. This commit changes all DSCs in edk2-platforms to drop the manual adding. Signed-off-by: Oliver Smith-Denny <[email protected]>
edk2 PR tianocore/edk2#6433 updated UefiCpuPkg's ResetVector to be USER_DEFINED. This updates VanGoghBoard's override to be compliant and not break with null libraries (such as the stack check lib) being linked globally. Signed-off-by: Oliver Smith-Denny <[email protected]>
edk2 PR tianocore/edk2#6433 updated UefiCpuPkg's ResetVector to be USER_DEFINED instead of SEC. This was also updated in VanGoghBoard's ResetVector override. As such, this commit updates the FDF rules for the ResetVector to be USER_DEFINED instead of SEC. Signed-off-by: Oliver Smith-Denny <[email protected]>
os-d
requested review from
vlsunil,
ardbiesheuvel,
leiflindholm,
JohnAZoidberg,
hrw,
ndhillonm,
wojtas-marcin,
kilaterlee,
lixianglai,
nate-desimone,
SaiChaganty,
ChaselChiu,
mdkinney,
samimujawar,
nhivp,
bexcran,
chuongtranle,
abdattar,
changab,
exinghr and
pbgrimes
as code owners
|
@mdkinney @ardbiesheuvel here is the PR to fix edk2-platforms after the breaking change |
nhivp
approved these changes
Nov 13, 2024
leiflindholm
approved these changes
Nov 13, 2024
abdattar
approved these changes
Nov 13, 2024
3 tasks
|
@nhivp @leiflindholm @samimujawar @abdattar , the edk2 PR this was dependent on has merged, please feel free to merge this when you are satisfied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edk2 PR tianocore/edk2#6433 cleaned up the null stack cookie implementation, no longer requiring DSCs to manually add the null stack cookie lib to Sec modules. In order to accomplish this, it updated the ResetVector to be USER_DEFINED instead of SEC. The three commits in this PR update edk2-platforms for this breaking change. This requires that edk2 PR 6433 be merged prior to this being merged.
Cleanup Null Stack Cookie Implementation
edk2 PR tianocore/edk2#6433 cleans up the null stack cookie implementation, no longer requiring DSCs to manually add the null stack cookie lib to Sec modules.
This commit changes all DSCs in edk2-platforms to drop the manual adding.
Update VanGoghBoard ResetVector Override
edk2 PR tianocore/edk2#6433 updated UefiCpuPkg's ResetVector to be USER_DEFINED. This updates VanGoghBoard's override to be compliant and not break with null libraries (such as the stack check lib) being linked globally.
Update FDF ResetVector Rules
edk2 PR tianocore/edk2#6433 updated UefiCpuPkg's ResetVector to be USER_DEFINED instead of SEC. This was also updated in VanGoghBoard's ResetVector override.
As such, this commit updates the FDF rules for the ResetVector to be USER_DEFINED instead of SEC.