Update to New StackCheckLib #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-d
requested review from
apalos,
samimujawar,
vlsunil,
ardbiesheuvel,
leiflindholm,
JohnAZoidberg,
hrw,
niruiyu,
ndhillonm,
wojtas-marcin,
kilaterlee,
lixianglai,
nate-desimone,
SaiChaganty,
ChaselChiu,
mdkinney,
changab,
heatd,
nhivp,
abdattar,
exinghr and
pbgrimes
as code owners
ardbiesheuvel
approved these changes
Sep 13, 2024
ndhillonm
approved these changes
Sep 13, 2024
ndhillonm
approved these changes
Sep 13, 2024
ndhillonm
approved these changes
Sep 13, 2024
|
Holding off on this until tianocore/edk2#6201 merges, will take the solution there to here. |
lgao4
approved these changes
Sep 14, 2024
nhivp
approved these changes
Sep 15, 2024
samimujawar
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
For Platform/ARM
Reviewed-by: Sami Mujawar [email protected]
|
This PR is ready to be merged now as we have reached agreement on the second edk2 PR. I will fix up the merge conflicts and push. |
3 tasks
edk2 PR tianocore/edk2#5957 removed BaseStackCheckLib and added StackCheckLibNull (amongst others). This PR updates all dscs/dsc.incs to remove the old BaseStackCheckLib and if appropriate, add StackCheckLibNull to LibraryClasses.common.SEC or to specific SEC libs. For all other component types, MdeLibs.dsc.inc links them to StackCheckLibNull. This does all dscs at once as it is formulaic and fixes build breaks. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Oliver Smith-Denny <[email protected]>
|
@samimujawar @ardbiesheuvel @hrw @nhivp @heatd @ndhillonm @leiflindholm I have rebased this PR to drop the two commits that have since merged to master and resolved the merge conflicts. Can we merge this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edk2 PR tianocore/edk2#5957 removed BaseStackCheckLib and added StackCheckLibNull (amongst others).
This PR updates all dscs/dsc.incs to remove the old BaseStackCheckLib and if appropriate, add StackCheckLibNull to LibraryClasses.common.SEC or to specific SEC libs. For all other component types, MdeLibs.dsc.inc links them to StackCheckLibNull.
This does all dscs at once as it is formulaic and fixes build breaks.
This PR currently contains two extra commits from #196 so that I do not have to rebase on every dsc. When that PR goes in, I will rebase this PR (should be no changes to this PR other than the two commits will be gone). Please view just Update to New StackCheckLib in the commit view.