[th/c-list] import c-list library as third-party module for internal use #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: third_party/c-list git-subtree-split: 9aa81d84cadc67e92b441c89f84c57e72dd1e8a9
…hird_party/c-list' Add "c-list" library ([1]). We already have an internal implementation for a circular, intrusive, doubly-linked list (in `include/netlink/list.h`). However, I think the "c-list" library is excellent, and in 2024 a netlink library should no longer reimplement a basic data structure. Vendor "c-list" via git-subtree. We want to strictly follow upstream (no local changes on our side) but re-import the library when there are new upstream changes. Existing users of <netlink/list.h> are not required to be rewritten. But new users should use "c-list.h". This is only an internal dependency, we anyway wouldn't want to expose such a list in our public API. [1] https://github.com/c-util/c-list Imported via: $ git subtree add --prefix third_party/c-list/ [email protected]:c-util/c-list.git main --squash Update with: $ git subtree pull --prefix third_party/c-list/ [email protected]:c-util/c-list.git main --squash
|
LGTM 👍 Could it be good to mention in the existing list implementation that new modules should prefer to use this implementation instead? |
This is mentioned both in the commit message and in the PR description here. Do you have anything else in mind? |
|
Probably just a note at the top of the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have an internal implementation for a circular, intrusive,
doubly-linked list (in
include/netlink/list.h).However, I think the "c-list" library is excellent, and in 2024 a
netlink library should no longer reimplement a basic data structure.
Vendor "c-list" via git-subtree. We want to strictly follow upstream (no
local changes on our side) but re-import the library when there are new
upstream changes.
Existing users of <netlink/list.h> are not required to be rewritten. But
new users should use "c-list.h". This is only an internal dependency, we
anyway wouldn't want to expose such a list in our public API.
[1] https://github.com/c-util/c-list
Imported via:
Update with: