-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route: treat routes with via nexthops as universe scoped as well #389
Conversation
RTA_VIA is a RTA_GATEWAY with added address family, so we should treat them them equivalent for guessing the scope. Signed-off-by: Jonas Gorski <[email protected]>
I didn't even touch that file ... |
this seems to be a change in behavior of clang-format in Fedora 40. That's a bit annoying. The version shipped by current Fedora 40 is the correct version for formatting. The file needs reformatting, I will do that. |
RTA_VIA is a RTA_GATEWAY with added address family, so we should treat them them equivalent for guessing the scope. Signed-off-by: Jonas Gorski <[email protected]> #389
merged as 3268820. Thank you for the patch!! |
if you use |
The weird/annyoing thing is that the "original" run ran fine with clang-format 18.1.1, but clang-format 18.1.6 now triggers this. A version bump that minor shouldn't change behaviour ... .
Well, since the file I touched was part of the ignored files in I did run a manual clang-format call on the file itself though, to make sure the code I touched is at least not introducing more issues. |
@KanjiMonster I think I would release libnl-3.10 soon. Do you have anything that still should go in and to wait for? There will also be a libnl-3.11 etc., so missing it may not be a problem. |
I have nothing urgent, so feel free to release whenever. All open things I have open are either too small to be a blocker, or too large to get fixed/implemented soon. We are using a heavily patched libnl anyway, so I'm no stranger to backporting things if I need them. |
RTA_VIA
is aRTA_GATEWAY
with added address family, so we should treat them them equivalent for guessing the scope.