Skip to content

Commit

Permalink
build: use "-std=gnu11" as compiler flags and depend on gcc's C11
Browse files Browse the repository at this point in the history
So far, we didn't specify "-std" option, and it was ill defined which C
behavior we require.

Note that we already use __attribute__((__cleanup__(fcn))), so
effectively we require either gcc or clang. A standard C compiler won't
suffice. That is for good reasons, because features like the cleanup
attribute are IMO invaluable and we should not write "C" without it.

Also, it's 2024. It's basically impossilbe that you use gcc/clang with a
version that doesn't yet support (gcc's) C11 variant. So explicitly
require that via the "-std=gnu11" option. I don't think we currently
require newer C features, so this is sufficient for us and for now.
  • Loading branch information
thom311 committed Nov 13, 2024
1 parent 8961887 commit 23c4e60
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ pkgconfig_DATA = \
libnl-xfrm-3.0.pc \
$(NULL)

extra_cppflags = \
-std=gnu11 \
$(NULL)

warn_cppflags = \
-Wall \
-Wextra \
Expand Down Expand Up @@ -394,6 +398,7 @@ default_includes = \
$(NULL)

default_cppflags = \
$(extra_cppflags) \
$(warn_cppflags) \
$(defines_cppflags) \
$(default_includes) \
Expand Down

0 comments on commit 23c4e60

Please sign in to comment.