Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make instructor usable with current mix phx.new install #59

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

thbar
Copy link
Collaborator

@thbar thbar commented Jun 2, 2024

Today while starting a brand new Phoenix app using instructor, I got this error message:

❯ mix deps.get
Resolving Hex dependencies...
Resolution completed in 0.687s
Because the lock depends on swoosh 1.16.9 which depends on req ~> 0.5 or ~> 1.0, the lock requires req ~> 0.5 or ~> 1.0.
And because every version of instructor depends on req ~> 0.4.0, the lock is incompatible with instructor.
And because your app depends on the lock, no version of instructor is allowed.
So, because your app depends on instructor ~> 0.0.5, version solving failed.
** (Mix) Hex dependency resolution failed

Swoosh is the default in Phoenix at the moment, and brings req via ~> 0.5 or ~> 1.0 (optional).

In this PR, I propose we follow the same pattern.

Feel free to adapt, my main goal is to make sure we can use instructor by default with new Phoenix installs.

If someone needs a quick fix until this gets merged

defp deps do
  [
    {:phoenix, "~> 1.7.12"},
    {:instructor, "~> 0.0.5", github: "thbar/instructor_ex", branch: "bump-req"},
    {:phoenix_ecto, "~> 4.4"},

@thmsmlr
Copy link
Owner

thmsmlr commented Jun 24, 2024

ty

@thmsmlr thmsmlr merged commit e852691 into thmsmlr:main Jun 24, 2024
1 check passed
@thbar thbar deleted the bump-req branch June 24, 2024 20:15
@stryderjzw stryderjzw mentioned this pull request Sep 11, 2024
@eugkhp
Copy link

eugkhp commented Dec 16, 2024

@thmsmlr hi! would it be possible to release a new version with this MR included to resolve issues like #73 ? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants