refactor: 무한스크롤 개선, 태그 검색 결과 페이지 prefetch 제거 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove Masonry component and useIntersect hook (It had a lot of bug) - add @egjs-infinitegrid - remove the feature of polling meme data from the cache
- waterfall 로 인한 지연 시간을 제거 하기 위함 - TagBookmarkButton 컴포넌트 Suspense 로 wrapping
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ojj1123
added a commit
that referenced
this pull request
Jan 19, 2024
* refactor: infinite scroll - remove Masonry component and useIntersect hook (It had a lot of bug) - add @egjs-infinitegrid - remove the feature of polling meme data from the cache * refactor: 사용하지 않는 컬러 제거 * refactor: 변수명 변경 * fix: 태그 검색 결과 페이지 서버에서 데이터 prefetch 제거 - waterfall 로 인한 지연 시간을 제거 하기 위함 - TagBookmarkButton 컴포넌트 Suspense 로 wrapping * refactor: 변수명 변경 * feat: error boundary fallback 에 홈으로 돌아가기 버튼 추가 * feat: PRD에서만 ga, gtag 활성화 * chore: 주석 추가
Merged
ojj1123
added a commit
that referenced
this pull request
Feb 5, 2024
* refactor: infinite scroll - remove Masonry component and useIntersect hook (It had a lot of bug) - add @egjs-infinitegrid - remove the feature of polling meme data from the cache * refactor: 사용하지 않는 컬러 제거 * refactor: 변수명 변경 * fix: 태그 검색 결과 페이지 서버에서 데이터 prefetch 제거 - waterfall 로 인한 지연 시간을 제거 하기 위함 - TagBookmarkButton 컴포넌트 Suspense 로 wrapping * refactor: 변수명 변경 * feat: error boundary fallback 에 홈으로 돌아가기 버튼 추가 * feat: PRD에서만 ga, gtag 활성화 * chore: 주석 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ 작업 내용
🌱 PR 포인트