Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Chore: Update PR template #5846

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 27, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the .github/pull_request_template.md file to enhance the pull request process by adding structured sections for issue tracking, reviewer notes, and testing instructions.

Detailed summary

  • Added a title section specifying the format for changes.
  • Introduced a prompt for issue tags from Linear.
  • Added a section for notes directed at reviewers.
  • Included a "How to test" section for testing instructions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 27, 2024

Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: a4f57be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:35am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:35am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:35am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:35am

Copy link

graphite-app bot commented Dec 27, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important things to call out? Be sure to also clarify these in your comments.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prompt "Anything important things" contains a grammatical error. Consider changing to "Any important things" to maintain correct English grammar.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (3e1bb53) to head (a4f57be).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5846   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files        1123     1123           
  Lines       59611    59611           
  Branches     5031     5031           
=======================================
  Hits        32895    32895           
  Misses      25996    25996           
  Partials      720      720           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7e2d1f3
packages 52.83% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.09 KB (0%) 902 ms (0%) 3.2 s (+16.4% 🔺) 4.1 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 7.3 s (+26.74% 🔺) 9.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 515 ms (+110.48% 🔺) 627 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 155 ms (-32.51% 🔽) 165 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 876 ms (+76.62% 🔺) 1.3 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant