Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Implemented query validation to enhance security and prevent potential SQL injection attacks.
What changed?
ValidateQuery
function inutils.go
to check for disallowed patterns and ensure only allowed functions are used in queries.ClickHouseConnector
methods for executing queries.logs_handlers.go
andtransactions_handlers.go
to potentially useBadRequestError
for disallowed functions.How to test?
sum
,count
,reinterpretAsUInt256
) and ensure they work as expected.Why make this change?
This change enhances the security of the application by preventing potential SQL injection attacks and restricting the use of potentially harmful functions or query patterns. It ensures that only safe, pre-approved functions can be used in queries, reducing the risk of unauthorized data access or manipulation.