Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip duplicate blocks in committer #112

Merged

Conversation

iuwqyir
Copy link
Collaborator

@iuwqyir iuwqyir commented Oct 24, 2024

TL;DR

Added duplicate block handling in the committer and comprehensive test coverage for the committer component.

What changed?

  • Added logic to skip duplicate blocks in the sequential block processing
  • Created new test file committer_test.go with extensive test coverage
  • Added test cases for duplicate block handling, gap detection, and committer functionality
  • Renamed reorg handler test to avoid naming conflicts

How to test?

  1. Run the test suite with go test ./internal/orchestrator
  2. Verify all committer tests pass, including:
    • Duplicate block handling
    • Sequential block processing
    • Gap detection
    • Committer initialization
    • Block commit operations

Why make this change?

The committer component previously lacked test coverage and could start filling gaps when encountering duplicate blocks. This change improves reliability by properly handling duplicate blocks and adds comprehensive testing to ensure the committer behaves correctly under various scenarios.

@iuwqyir iuwqyir changed the title fix committing when duplicated blocks in staging Skip duplicate blocks in committer Oct 24, 2024
Copy link
Collaborator Author

iuwqyir commented Oct 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iuwqyir and the rest of your teammates on Graphite Graphite

@iuwqyir iuwqyir marked this pull request as ready for review October 24, 2024 11:12
@iuwqyir iuwqyir merged commit c6fc50e into main Oct 24, 2024
5 checks passed
@iuwqyir iuwqyir deleted the 10-24-fix_committing_when_duplicated_blocks_in_staging branch October 24, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants