Address balance listener worker #819
Conversation
| @@ -236,6 +236,10 @@ export const getConfiguration = async (): Promise<ParsedConfig> => { | |||
| config = await updateConfiguration({ | |||
| indexerListenerCronSchedule: "*/5 * * * * *", | |||
| }); | |||
| } else if (!config.addressBalanceListenerCronSchedule) { | |||
| config = await updateConfiguration({ | |||
| addressBalanceListenerCronSchedule: "0 */5 * * * *", | |||
There was a problem hiding this comment.
Is 5 minutes a good poll interval?
There was a problem hiding this comment.
In the current implementation, in order to create a balance listener, a user creates a webhook with a config (newly added field), where a user can specify options like address, chainId and threshold).
The webhooks table is mostly intended to store URLs that engine should call, and business logic/config pertaining to when and why should live elsewhere.
We utilise webhooks today for contract subscription, where the flow is to first create a webhook, and then setting up a subscription (this is where the business logic/config resides, like which contract to listen to, which events to index etc).
A similar pattern could be used here. We create a new balance-subscriptions table and endpoint. Logic/config related to the subscription should reside here (we can even expand later beyond this original scope, adding things like tracking erc20 balances). To make it general, we could have the threshold subscription be an optional configuration, default behaviour being we report any balance changes. IMO config should not be inside the webhook table.
|
The main idea of having config in webhook table it to prevent creating multiple tables. Each webhook already has a type which can be used to perform specific tasks and should they require additional configurability, the config column helps specify it. It is an optional I had a discussing with @arcoraven before doing it this way as I wasn't sure if I should create a new table just for the config or just add it to the existing table. |
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
PR-Codex overview
This PR introduces a new
configcolumn in thewebhooksandconfigurationtables, enhances the webhook creation process to include configuration details, and implements anaddressBalanceListenerthat triggers webhooks based on address balance thresholds.Detailed summary
configcolumn towebhooksandconfigurationtables.get-configuration.tsto initializeaddressBalanceListenerCronSchedule.toWebhookSchemato includeconfig.createWebhookRouteto handleconfig.addressBalanceListenerto track address balance changes.trackAddressBalanceto enqueue webhooks based on balance thresholds.