Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-balance and get-all-events migrated to v5 #816

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

nischitpra
Copy link
Contributor

@nischitpra nischitpra commented Dec 12, 2024

PR-Codex overview

This PR focuses on migrating the wallet and contract event functionalities from version 4 to version 5 of the thirdweb SDK, ensuring backward compatibility and implementing new methods for fetching wallet balances and contract events.

Detailed summary

  • Replaced getSdk with thirdwebClient and updated balance fetching in get-balance.ts.
  • Added new types ContractEventV4 and ContractEventV5 in event.ts for event handling.
  • Introduced toContractEventV4Schema function for backward compatibility.
  • Updated get-all-events.ts to use getContractEvents and map to ContractEventV4.
  • Added unit tests for migration validation in migrationV5.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nischitpra nischitpra merged commit 5b34cfa into main Dec 12, 2024
6 checks passed
@nischitpra nischitpra deleted the np/apiV5migration branch December 12, 2024 09:30
arcoraven pushed a commit that referenced this pull request Dec 31, 2024
arcoraven added a commit that referenced this pull request Dec 31, 2024
* regenerate sdk (#808)

Co-authored-by: Phillip Ho <[email protected]>
Signed-off-by: Phillip Ho <[email protected]>

* bump sdk version (#813)

Signed-off-by: Phillip Ho <[email protected]>

* update workflow action versions (#812)

Signed-off-by: Phillip Ho <[email protected]>

* fix all biome errors (#815)

* bump yarn to berry

* fix all biome errors

* bring back pinned resolved deps, fix whitepsace

---------

Co-authored-by: Phillip Ho <[email protected]>
Signed-off-by: Phillip Ho <[email protected]>

* get-balance and get-all-events migrated to v5 (#816)

Signed-off-by: Phillip Ho <[email protected]>

* thirdweb version bump (#818)

thirdweb sdk version bump to v5.78.0

Signed-off-by: Phillip Ho <[email protected]>

* chore: fix some typos in comment

Signed-off-by: toofooboo <[email protected]>
Signed-off-by: Phillip Ho <[email protected]>

---------

Signed-off-by: Phillip Ho <[email protected]>
Signed-off-by: toofooboo <[email protected]>
Co-authored-by: Nicholas St. Germain <[email protected]>
Co-authored-by: Nischit Prasad Nhuchhe Pradhan <[email protected]>
Co-authored-by: toofooboo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants