Change InMemoryStorage to generating new ids

thiagodp · May 15, 2024 · 7b45d8d · 7b45d8d
1 parent 8fac220
commit 7b45d8d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/spec/InMemoryStorage.spec.php b/spec/InMemoryStorage.spec.php
@@ -30,4 +30,12 @@
 
     } );
 
+    it( 'generates an incremental id every new flag', function() {
+        $storage = new InMemoryStorage();
+        $foo = $storage->touch( 'foo' );
+        expect( $foo->metadata->id )->toBe( 1 );
+        $bar = $storage->touch( 'bar' );
+        expect( $bar->metadata->id )->toBe( 2 );
+    } );
+
 } );
diff --git a/src/storages/InMemoryStorage.php b/src/storages/InMemoryStorage.php
@@ -9,6 +9,8 @@ class InMemoryStorage implements FlagStorage {
     /** @var array<string, FlagData> */
     private array $flags = [];
 
+    private int $lastId = 0;
+
     public function isEnabled( string $key ): bool {
         $flag = $this->get( $key );
         return $flag === null ? false : $flag->enabled;
@@ -21,8 +23,9 @@ public function get( string $key ): ?FlagData {
 
     /** @inheritDoc */
     public function touch( string $key, ?bool $enabled = null ): ?FlagData {
+
         $flag = $this->get( $key ) ??
-            new FlagData( $key, false, new FlagMetadata() );
+            new FlagData( $key, false, new FlagMetadata( ++$this->lastId ) );
 
         $this->set( $key, $flag );