Skip to content

Commit

Permalink
ci: Restore Edge on Windows in the lab (shaka-project#6220)
Browse files Browse the repository at this point in the history
By specifying the binary path and also merging
shaka-project/shaka-lab#47, we are able to
restore Edge on Windows in the lab.
  • Loading branch information
joeyparrish authored Feb 6, 2024
1 parent 5b7d7b2 commit 59451e6
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions build/shaka-lab.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,18 @@ vars:
ms:edgeOptions:
binary: /usr/bin/microsoft-edge

# Work around https://github.com/MicrosoftEdge/EdgeWebDriver/issues/102#issuecomment-1710724173
# by specifying the binary path on Mac.
edge_mac_config: &edge_mac_config
ms:edgeOptions:
binary: /Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge

# Work around https://github.com/MicrosoftEdge/EdgeWebDriver/issues/102#issuecomment-1710724173
# by specifying the binary path on Mac.
edge_windows_config: &edge_windows_config
ms:edgeOptions:
binary: "C:/Program Files (x86)/Microsoft/Edge/Application/msedge.exe"

android_chrome_config: &android_chrome_config
goog:chromeOptions:
args:
Expand Down Expand Up @@ -132,6 +144,7 @@ EdgeMac:
os: Mac
extra_configs:
- *basic_edge_config
- *edge_mac_config

Safari:
browser: safari
Expand Down Expand Up @@ -161,12 +174,11 @@ FirefoxWindows:
- *basic_firefox_config

Edge:
# TODO(b/323916397): Edge on Windows not working currently
disabled: true
browser: msedge
os: Windows
extra_configs:
- *basic_edge_config
- *edge_windows_config


### Linux ###
Expand Down

0 comments on commit 59451e6

Please sign in to comment.