Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: back merge utils for truncate title #4697

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

byhow
Copy link
Contributor

@byhow byhow commented Jul 30, 2024

This is for unifying the notice title truncation utils across components. The first commit of this PR is just cherry-picking, while the second commit is for refactoring.

re: #4686

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
matters-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 6:43am

@byhow byhow marked this pull request as ready for review July 30, 2024 06:46
@byhow byhow requested a review from a team as a code owner July 30, 2024 06:46
@byhow byhow merged commit 5f7f67f into feat/journal Jul 30, 2024
5 of 6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chore/back-merge-truncate-utils branch July 30, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants