fix: fix tests

thematters · May 2, 2024 · e45117a · e45117a
1 parent c9c4520
commit e45117a
Show file tree

Hide file tree

Showing 15 changed files with 16 additions and 22 deletions.
diff --git a/src/components/ArticleDigest/Archived/Archived.test.tsx b/src/components/ArticleDigest/Archived/Archived.test.tsx
@@ -17,6 +17,6 @@ describe('<ArticleDigest.Archived>', () => {
     expect($title).toBeInTheDocument()
 
     $title.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
   })
 })
diff --git a/src/components/ArticleDigest/Archived/index.tsx b/src/components/ArticleDigest/Archived/index.tsx
@@ -1,7 +1,6 @@
 import React from 'react'
 
 import { TEST_ID } from '~/common/enums'
-import { UtmParams } from '~/common/utils'
 import { DateTime } from '~/components'
 import { ArticleDigestTitleArticleFragment } from '~/gql/graphql'
 
@@ -10,12 +9,10 @@ import styles from './styles.module.css'
 
 export type ArticleDigestArchivedProps = {
   article: ArticleDigestTitleArticleFragment & { createdAt: string }
-} & UtmParams
+}
 
 export const ArticleDigestArchived = ({
   article,
-  utm_source,
-  utm_medium,
 }: ArticleDigestArchivedProps) => {
   return (
     <section

diff --git a/src/components/ArticleDigest/Card/Card.test.tsx b/src/components/ArticleDigest/Card/Card.test.tsx
@@ -29,7 +29,7 @@ describe('<ArticleDigest.Card>', () => {
     expect($author).toBeInTheDocument()
 
     $digest.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).toHaveBeenCalled()
 
     $author.click()

diff --git a/src/components/ArticleDigest/Curated/Curated.test.tsx b/src/components/ArticleDigest/Curated/Curated.test.tsx
@@ -32,7 +32,7 @@ describe('<ArticleDigest.Curated>', () => {
     expect($author).toBeInTheDocument()
 
     $digest.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).toHaveBeenCalled()
 
     $author.click()

diff --git a/src/components/ArticleDigest/Dropdown/Dropdown.test.tsx b/src/components/ArticleDigest/Dropdown/Dropdown.test.tsx
@@ -27,7 +27,7 @@ describe('<ArticleDigest.Dropdown>', () => {
     expect($author).toBeInTheDocument()
 
     $digest.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).toHaveBeenCalled()
   })
 
@@ -52,7 +52,7 @@ describe('<ArticleDigest.Dropdown>', () => {
     expect($author).toBeInTheDocument()
 
     $digest.click()
-    expect(mockRouter.asPath).not.toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).not.toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).not.toHaveBeenCalled()
   })
 })
diff --git a/src/components/ArticleDigest/Feed/Feed.test.tsx b/src/components/ArticleDigest/Feed/Feed.test.tsx
@@ -25,7 +25,7 @@ describe('<ArticleDigest.Feed>', () => {
     const $title = screen.getByRole('heading', { name: MOCK_ARTILCE.title })
     expect($title).toBeInTheDocument()
     $title.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).toBeCalledTimes(1)
 
     mockRouter.back()
@@ -34,7 +34,7 @@ describe('<ArticleDigest.Feed>', () => {
     const $summary = screen.getByText(MOCK_ARTILCE.summary)
     expect($summary).toBeInTheDocument()
     $summary.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).toBeCalledTimes(2)
 
     mockRouter.back()

diff --git a/src/components/ArticleDigest/List/List.test.tsx b/src/components/ArticleDigest/List/List.test.tsx
@@ -24,7 +24,7 @@ describe('<ArticleDigest.List>', () => {
     expect($author).toBeInTheDocument()
 
     $digest.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).toHaveBeenCalled()
   })
 })
diff --git a/src/components/ArticleDigest/Notice/Notice.test.tsx b/src/components/ArticleDigest/Notice/Notice.test.tsx
@@ -20,6 +20,6 @@ describe('<ArticleDigest.Notice>', () => {
     expect($summary).toBeInTheDocument()
 
     $digest.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
   })
 })
diff --git a/src/components/ArticleDigest/Published/Published.test.tsx b/src/components/ArticleDigest/Published/Published.test.tsx
@@ -37,7 +37,7 @@ describe('<ArticleDigest.Published>', () => {
     const $title = screen.getByRole('heading', { name: MOCK_ARTILCE.title })
     expect($title).toBeInTheDocument()
     $title.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
 
     mockRouter.back()
   })

diff --git a/src/components/ArticleDigest/Sidebar/Sidebar.test.tsx b/src/components/ArticleDigest/Sidebar/Sidebar.test.tsx
@@ -29,7 +29,7 @@ describe('<ArticleDigest.Sidebar>', () => {
     expect($author).toBeInTheDocument()
 
     $digest.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).toHaveBeenCalled()
 
     $author.click()

diff --git a/src/components/ArticleDigest/Title/Title.test.tsx b/src/components/ArticleDigest/Title/Title.test.tsx
@@ -19,7 +19,7 @@ describe('<ArticleDigest.Title>', () => {
     expect($title).toBeInTheDocument()
 
     $title.click()
-    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).toHaveBeenCalled()
   })
 
@@ -56,7 +56,7 @@ describe('<ArticleDigest.Title>', () => {
     })
 
     $title.click()
-    expect(mockRouter.asPath).not.toContain(MOCK_ARTILCE.slug)
+    expect(mockRouter.asPath).not.toContain(MOCK_ARTILCE.shortHash)
     expect(handleClickDigest).not.toHaveBeenCalled()
   })
 

diff --git a/src/components/Comment/CreatedAt/CreatedAt.test.tsx b/src/components/Comment/CreatedAt/CreatedAt.test.tsx
@@ -13,7 +13,7 @@ describe('<Comemnt/CreatedAt>', () => {
     expect($time).toBeInTheDocument()
 
     $time.click()
-    expect(mockRouter.asPath).toContain(MOCK_COMMENT.node.slug)
+    expect(mockRouter.asPath).toContain(MOCK_COMMENT.id)
   })
 
   it('should render a Comment/CreatedAt without link', () => {

diff --git a/src/components/Context/CommentDrafts/index.tsx b/src/components/Context/CommentDrafts/index.tsx
@@ -96,7 +96,6 @@ export const CommentDraftsProvider = ({
         }
 
         const allEmptyDraft = checkAllDraftsEmpty()
-        console.log({ allEmptyDraft, drafts })
         if (allEmptyDraft) {
           navigateTo(url)
         } else {

diff --git a/src/components/Forms/PaymentForm/PayTo/CurrencyChoice/USDTChoice.tsx b/src/components/Forms/PaymentForm/PayTo/CurrencyChoice/USDTChoice.tsx
@@ -51,7 +51,7 @@ const USDTChoice: React.FC<FormProps> = ({
   const curatorAddress = viewer.info.ethAddress
   const creatorAddress = recipient.info.ethAddress
 
-  if (mediaHash === '') {
+  if (!mediaHash) {
     return (
       <section className={styles.item}>
         <TextIcon

diff --git a/src/components/TextIcon/index.tsx b/src/components/TextIcon/index.tsx
@@ -79,8 +79,6 @@ export const TextIcon: React.FC<React.PropsWithChildren<TextIconProps>> = ({
     [styles.hasIcon]: !!icon,
   })
 
-  console.log({ spacing, textIconClasses })
-
   if (placement === 'left') {
     return (
       <span className={textIconClasses} {...restProps}>